Migration to last.fm, removed old spotify api client. FOSRestBundle API serving data driven front end (JWT).

docs/architecture.md

@@ -6,19 +6,19 @@ This project follows a conventional Symfony architecture with clear separation o
 
 - **Classes**
   - **Controllers** end with `Controller` (e.g. `AlbumController`) and expose HTTP‑oriented actions with verb‑based method names (`search`, `show`, `edit`, `delete`).
-  - **Services** are named by capability, not by caller, using nouns or noun‑phrases (e.g. `AlbumSearchService`, `ConsoleCommandRunner`, `RegistrationToggle`). When a service is tightly scoped to a third‑party, the integration appears in the name (e.g. `SpotifyClient`, `SpotifyMetadataRefresher`).
+  - **Services** are named by capability, not by caller, using nouns or noun‑phrases (e.g. `AlbumSearchService`, `ConsoleCommandRunner`, `RegistrationToggle`). When a service is tightly scoped to a third‑party, the integration appears in the name (e.g. `LastFmClient`, `LastFmMetadataRefresher`).
   - **Entities** are singular domain nouns (`Album`, `Review`, `User`) and avoid transport or UI details.
   - **Commands** describe what they do and the environment they are meant for (e.g. `SeedDemoUsersCommand`, `PromoteAdminCommand`).
 
 - **Methods**
-  - Use **verb‑based, intention‑revealing names** that describe *what* the method does, not *how* it is used (e.g. `refreshAllSpotifyAlbums()`, `resetCatalog()`, `runConsoleCommand()`, `isEnabled()`, `findAlbumByPublicId()`).
-  - Accessors start with `get*`, `set*`, `is*` / `has*` for booleans (e.g. `getEnvOverride()`, `isSpotifyConfigured()`).
+  - Use **verb‑based, intention‑revealing names** that describe *what* the method does, not *how* it is used (e.g. `refreshAllExternalAlbums()`, `resetCatalog()`, `runConsoleCommand()`, `isEnabled()`, `findAlbumByPublicId()`).
+  - Accessors start with `get*`, `set*`, `is*` / `has*` for booleans (e.g. `getEnvOverride()`, `isExternalConfigured()`).
   - Avoid ambiguous names like `run()`, `handle()`, or `process()` without a clear domain object; prefer `runConsoleCommand()`, `handleAlbumCoverUpload()`, etc.
 
 - **Variables & parameters**
-  - Use **descriptive, domain‑level names** (e.g. `$albumRepository`, `$reviewCount`, `$spotifyAlbumPayload`) and avoid unclear abbreviations (`$em` is acceptable for `EntityManagerInterface` in local scope, but prefer full names for properties).
-  - Booleans read naturally (`$isEnabled`, `$shouldQuerySpotify`, `$needsSync`).
-  - Collections are pluralized (`$albums`, `$userReviews`, `$spotifyIds`).
+  - Use **descriptive, domain‑level names** (e.g. `$albumRepository`, `$reviewCount`, `$lastfmAlbumPayload`) and avoid unclear abbreviations (`$em` is acceptable for `EntityManagerInterface` in local scope, but prefer full names for properties).
+  - Booleans read naturally (`$isEnabled`, `$shouldQueryLast.fm`, `$needsSync`).
+  - Collections are pluralized (`$albums`, `$userReviews`, `$lastfmIds`).
 
 - **Files & namespaces**
   - File names match their primary class name and follow PSR‑4 (e.g. `src/Service/AlbumSearchService.php` for `App\Service\AlbumSearchService`).
@@ -27,10 +27,10 @@ This project follows a conventional Symfony architecture with clear separation o
 These conventions should be followed for all new PHP code and when refactoring existing classes to keep the codebase reusable and self‑documenting.
 
 ## High-level flow
-1. Visitors search for albums (Spotify) and view an album page
+1. Visitors search for albums (Last.fm) and view an album page
 2. Logged‑in users can write, edit, and delete reviews
 3. Moderators and admins can moderate content and manage users
-4. Admins configure site settings (Spotify credentials, registration toggle)
+4. Admins configure site settings (Last.fm credentials, registration toggle)
 
 ## Layers & components
 
@@ -45,7 +45,7 @@ These conventions should be followed for all new PHP code and when refactoring e
 - `User` — authentication principal and roles
 - `Album`, `AlbumTrack` — normalized album metadata and track list
 - `Review` — user‑authored review with rating and timestamps
-- `Setting` — key/value store for site configuration (e.g., Spotify credentials)
+- `Setting` — key/value store for site configuration (e.g., Last.fm credentials)
 
 ### Repositories (`src/Repository/*`)
 - Doctrine repositories for querying by domain (albums, tracks, reviews, settings, users)
@@ -55,10 +55,10 @@ These conventions should be followed for all new PHP code and when refactoring e
 - Leverage Symfony validation constraints for robust server‑side validation
 
 ### Services (`src/Service/*`)
-- `SpotifyClient` — Client Credentials token management (cached) and API calls
-- `SpotifyMetadataRefresher`, `SpotifyGenreResolver` — helpers for richer album data
+- `LastFmClient` — Last.fm API integration with caching
+- `LastFmMetadataRefresher`, `LastFmTagResolver` — helpers for richer album data
 - `CatalogResetService` — admin action to reset/sync catalog state safely
-- `ImageStorage` — avatar uploads and related image handling
+- `UploadStorage` — avatar/album image uploads and related file handling
 - `RegistrationToggle` — DB‑backed registration flag with env override
 
 ### Security (`config/packages/security.yaml`, `src/Security/*`)
@@ -86,5 +86,3 @@ These conventions should be followed for all new PHP code and when refactoring e
 ## Testing & tooling
 - PHPUnit setup in `composer.json` (`phpunit/phpunit`), BrowserKit & CSS Selector for functional coverage
 - Web Profiler enabled in dev
-
-